-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(rln): add ark-zkey support #242
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this PR! comments are inline
perhaps we need to shallow clone the repo in the benchmarks github job/? |
wouldn't that just make a dependency conflict? I mean between their patch wasmer and release wasmer? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, comments inline :)
yup, but we should try to find a way for the benchmarks to run in CI before we can merge this :) |
Benchmark for 88670dbClick to view benchmark
|
Benchmark for 88670dbClick to view benchmark
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
For now
makefile
doesn't work correct because of using wholemopro
project as submodule. The problem is thatmopro
uses a patch forwasmer
andzerokit
doesn't and as a result there is a conflict in dependencies.In general benchmark and tests are working if it runs by
cargo bench/tests
.So I opened an issue to publish
ark-key
as a library and will wait for the result. In the meantime, I will try to pull up only part of the sub-module as a kludge solution and do some other tasksPart of #237