Add function for checking indices of leaves which are set to zero #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for 80b3da6Click to view benchmark
|
Benchmark for 576e171Click to view benchmark
|
Benchmark for 576e171Click to view benchmark
|
rymnc
reviewed
May 16, 2024
Comment on lines
+203
to
+230
| self.cached_leaves_indices | ||
| .iter() | ||
| .take(next_idx) | ||
| .enumerate() | ||
| .filter(|&(_, &v)| v == 0u8) | ||
| .map(|(idx, _)| idx) | ||
| .collect() |
There was a problem hiding this comment.
not sure if this is the best way to handle finding zero elements
perhaps we can employ a bloom filter and set values there?
quick napkin math suggests that we may use just ~3.5mb of memory vs 33mb
vec approach: 1048576 elements * 32 = 33mb at the cost of good performance
bloom filter: m = ceil((n * log(p)) / log(1 / pow(2, log(2)))) where n = 1048576, p = 1000k = 3.59mb
There was a problem hiding this comment.
hm, I need to think about it
If I think correctly, it will require rebuilding the filter every time we increase next_index? I'm not sure how much cost filter updating
oh, It's just misprint in function name, thank you for noticed |
Benchmark for 911e860Click to view benchmark
|
Benchmark for 911e860Click to view benchmark
|
seemenkina
force-pushed
the
tree-reconciliation
branch
from
b1c6fcd to
0e0dfc2
Compare
Benchmark for 3a20f37Click to view benchmark
|
Benchmark for 3a20f37Click to view benchmark
|
Benchmark for 81048f0Click to view benchmark
|
Benchmark for 81048f0Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #237
In general everything is ready, tests that helped to find problems from #248 are commented out for now.