refactor(rln): improve circuit loading performances and tests fix #26
Conversation
| const ZKEY_FILENAME: &str = "rln_final.zkey"; | ||
| const VK_FILENAME: &str = "verifying_key.json"; | ||
| const R1CS_FILENAME: &str = "rln.r1cs"; |
There was a problem hiding this comment.
Is the r1cs file not useful for debugging? https://github.com/iden3/r1csfile/blob/master/doc/r1cs_bin_format.md
There was a problem hiding this comment.
I expect most of the (circuit) debugging to be done in circom, not in zerokit. Here we just plug a verified/tested circuit compiled in circom and use it to generate proofs. If I get your concerns correctly, the debugging phase should happen before the compiled circuit is embedded in zerokit. Of course you might find some unexpected behaviors while using zerokit, but then it would most probably be a bad circuit implementation, hence you're back to circom. Does this address your concern?
There was a problem hiding this comment.
hmm, not sure
I think you are correct most debugging will happen at circom level, but I also see the need for debugging generally as well as for perf etc in Zerokit
but let's cross that bridge when we get there and ignore for now
This PR implements a different circuit loading mechanism -inspired by semaphore-rs one's- in order to address some performance issues described in #23.
In particular, we replace the previous ark-circom CircomBuilder object used to load circuit and generate witnesses, with a witness generator obtained directly from the circuit .WASM file. As a result the .R1C1 is no more needed. These changes result in a more efficient zkSNARK proof generation.
This PR further fixes some tests for tree height equal 20 that were previously failing, due to missing/wrong hard-coded assert values.