Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rln): add extended keygen APIs for Semaphore-compatible credentials #85

Merged
merged 7 commits into from
Dec 11, 2022

Conversation

s1fr0
Copy link
Contributor

@s1fr0 s1fr0 commented Dec 6, 2022

This PR addresses #81 by adding the public/FFI APIs extended_key_gen and seeded_extended_key_gen that generate (identity_trapdoor, identity_nullifier, identity_secret, id_commitment) tuples to have credentials compatible for both Semaphore and RLN.

Tests are added too.

This PR is based on the update-circuit branch and will be rebased once the corresponding PR #84 will be merged.

@s1fr0 s1fr0 added the track:zerokit Zerokit track (Applied ZK/Explorations) label Dec 6, 2022
@s1fr0 s1fr0 requested review from richard-ramos and rymnc December 6, 2022 23:50
@s1fr0 s1fr0 self-assigned this Dec 6, 2022
Copy link
Contributor

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor change to the deserialization function :)

@s1fr0 s1fr0 added the blocked This issue is blocked by some other work label Dec 9, 2022
@s1fr0 s1fr0 linked an issue Dec 9, 2022 that may be closed by this pull request
Copy link
Member

@richard-ramos richard-ramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@s1fr0 s1fr0 removed the blocked This issue is blocked by some other work label Dec 9, 2022
@s1fr0 s1fr0 merged commit 32f3202 into master Dec 11, 2022
@rymnc rymnc deleted the semaphore-keygen branch December 12, 2022 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
track:zerokit Zerokit track (Applied ZK/Explorations)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RLN: Update identity_secret generation
3 participants