refactor address derivation, discovery and crypto providers

app/frontend/actions.js

@@ -1,6 +1,6 @@
 const {generateMnemonic} = require('./wallet/mnemonic')
 const {ADALITE_CONFIG} = require('./config')
-const {DERIVATION_SCHEMES} = require('./wallet/constants')
+const derivationSchemes = require('./wallet/derivation-schemes')
 const FileSaver = require('file-saver')
 const {
   sendAddressValidator,
@@ -67,20 +67,12 @@ module.exports = ({setState, getState}) => {
     loadingAction(state, 'Loading wallet data...', {walletLoadingError: undefined})
     switch (cryptoProvider) {
       case 'trezor':
-        try {
-          wallet = await Cardano.CardanoWallet({
-            cryptoProvider: 'trezor',
-            config: ADALITE_CONFIG,
-            network: 'mainnet',
-            derivationScheme: DERIVATION_SCHEMES.v2,
-          })
-        } catch (e) {
-          debugLog(e)
-          return setState({
-            loading: false,
-            walletLoadingError: {code: 'TrezorRejected'},
-          })
-        }
+        wallet = await Cardano.CardanoWallet({
+          cryptoProvider: 'trezor',
+          config: ADALITE_CONFIG,
+          network: 'mainnet',
+          derivationScheme: derivationSchemes.v2,
+        })
         break
       case 'mnemonic':
         secret = secret.trim()
@@ -89,7 +81,7 @@ module.exports = ({setState, getState}) => {
           mnemonicOrHdNodeString: secret,
           config: ADALITE_CONFIG,
           network: 'mainnet',
-          derivationScheme: DERIVATION_SCHEMES.v1,
+          derivationScheme: derivationSchemes.v1,
         })
         break
       default:
@@ -103,7 +95,7 @@ module.exports = ({setState, getState}) => {
     }
     try {
       const walletIsLoaded = true
-      const ownAddressesWithMeta = await wallet.getOwnAddressesWithMeta()
+      const ownAddressesWithMeta = await wallet.getVisibleAddressesWithMeta()
       const transactionHistory = await wallet.getHistory()
       const balance = await wallet.getBalance()
       const conversionRates = getConversionRates(state)
@@ -138,11 +130,12 @@ module.exports = ({setState, getState}) => {
         })
       }
     } catch (e) {
-      debugLog(e.toString())
+      debugLog(e)
       setState({
         walletLoadingError: {
           code: 'WalletInitializationError',
         },
+        loading: false,
       })
     }
     return true
@@ -238,7 +231,7 @@ module.exports = ({setState, getState}) => {
     loadingAction(state, 'Reloading wallet info...')
 
     const balance = await wallet.getBalance()
-    const ownAddressesWithMeta = await wallet.getOwnAddressesWithMeta()
+    const ownAddressesWithMeta = await wallet.getVisibleAddressesWithMeta()
     const transactionHistory = await wallet.getHistory()
     const conversionRates = getConversionRates(state)
 
@@ -254,9 +247,10 @@ module.exports = ({setState, getState}) => {
         conversionRates: await conversionRates,
       })
     } catch (e) {
-      debugLog('Could not fetch conversion rates.')
+      debugLog(`Could not fetch conversion rates: ${e}`)
       setState({
         conversionRates: null,
+        loading: false,
       })
     }
   }

app/frontend/components/pages/receiveAda/addressContainer.js

@@ -12,7 +12,7 @@ const AddressContainer = connect(
   h(
     'div',
     {class: 'address-wrap'},
-    h('b', {class: 'address address-start no-events'}, `/${bip32path.split('/')[5]}`),
+    h('b', {class: 'address address-start no-events'}, `/${bip32path.split('/').pop()}`),
     h(
       'span',
       {class: 'address shrinked no-events'},

app/frontend/helpers/debugLog.js

@@ -1,11 +1,17 @@
 const ADALITE_CONFIG = require('../config').ADALITE_CONFIG
 
-function debugLog(message) {
+function debugLog(item) {
   // patched to work with tests, added `ADALITE_CONFIG &&`,
   // because config is loaded from html body, which is not present in tests
   if (ADALITE_CONFIG && ADALITE_CONFIG.ADALITE_ENABLE_DEBUGGING) {
+    let msgToLog = ''
+    if (item instanceof Error) {
+      msgToLog = JSON.stringify(item, Object.getOwnPropertyNames(item))
+    } else {
+      msgToLog = item
+    }
     // eslint-disable-next-line no-console
-    console.error(message)
+    console.error(msgToLog)
   }
 }
 

app/frontend/wallet/address-manager.js

@@ -0,0 +1,78 @@
+const range = require('./helpers/range')
+const {toBip32StringPath} = require('./helpers/bip32')
+const {packAddress} = require('cardano-crypto.js')
+
+const AddressManager = ({
+  accountIndex,
+  addressLimit,
+  cryptoProvider,
+  derivationScheme,
+  disableCaching, // good for tests
+  isChange,
+}) => {
+  const state = {
+    deriveAddressMemo: {},
+  }
+
+  function discoverAddresses() {
+    const childIndexBegin = derivationScheme.startAddressIndex
+    const childIndexEnd = childIndexBegin + addressLimit
+    const absDerivationPaths = range(childIndexBegin, childIndexEnd)
+      .map((i) => [accountIndex, isChange ? 1 : 0, i])
+      .map(derivationScheme.toAbsoluteDerivationPath)
+
+    return deriveAddresses(absDerivationPaths)
+  }
+
+  async function discoverAddressesWithMeta() {
+    return (await discoverAddresses()).map((address) => {
+      return {
+        address,
+        bip32StringPath: toBip32StringPath(getAddressToAbsPathMapping()[address]),
+      }
+    })
+  }
+
+  function deriveAddresses(absDerivationPaths) {
+    return Promise.all(absDerivationPaths.map(deriveAddress))
+  }
+
+  async function deriveAddress(absDerivationPath) {
+    // in derivation scheme 1, the middle part of the derivation path is skipped
+    const memoKey = JSON.stringify(absDerivationPath)
+
+    if (!state.deriveAddressMemo[memoKey] || disableCaching) {
+      const xpub = await cryptoProvider.deriveXpub(absDerivationPath)
+      const hdPassphrase =
+        derivationScheme.type === 'v1' ? await cryptoProvider.getHdPassphrase() : undefined
+
+      state.deriveAddressMemo[memoKey] = packAddress(
+        absDerivationPath,
+        xpub,
+        hdPassphrase,
+        derivationScheme.number
+      )
+    }
+
+    return state.deriveAddressMemo[memoKey]
+  }
+
+  function getAddressToAbsPathMapping() {
+    const result = {}
+    Object.keys(state.deriveAddressMemo).map((key) => {
+      result[state.deriveAddressMemo[key]] = JSON.parse(key)
+    })
+
+    return result
+  }
+
+  return {
+    discoverAddresses,
+    discoverAddressesWithMeta,
+    getAddressToAbsPathMapping,
+    _deriveAddress: deriveAddress,
+    _deriveAddresses: deriveAddresses,
+  }
+}
+
+module.exports = AddressManager

app/frontend/wallet/blockchain-explorer.js

@@ -89,7 +89,7 @@ const blockchainExplorer = (ADALITE_CONFIG, walletState) => {
 
   function getAddressInfo(address) {
     const addressInfo = state.addressInfos[address]
-    const maxAddressInfoAge = 10000
+    const maxAddressInfoAge = 15000
 
     if (!addressInfo || Date.now() - addressInfo.timestamp > maxAddressInfoAge) {
       state.addressInfos[address] = {