Multiassets #54
Multiassets #54
Conversation
janmazak
force-pushed
the
multiasset
branch
2 times, most recently
from
da7747a
to
b412350
Compare
| HANDLE_VALIDITY_INTERVAL_START_STEP_INVALID, | ||
| }; | ||
|
|
||
| static void signTx_handleValidityInterval_ui_runStep() |
There was a problem hiding this comment.
UX-wise I find it a bit counterintuitive that validity interval start is being confirmed after TTL, but I guess reversing the order is not really an option given that it's coupled with tx serialization :/
I'm wondering if it would not make sense to (eventually) move ttl/validity start directly to the init APDU to make the UX around those values more intuitive and remove that "machinery" just for two numbers
There was a problem hiding this comment.
I don't understand why they did not just replace ttl with validity interval (in the same way as coin in output is replaced by coin / [coin, multiasset]). That would fix all ui problems and also look more natural.
On one hand, we don't have much time to do changes; on the other, why show the users the "wrong" user flow with validity interval if we can avoid it?...
|
@janmazak don't forget to update the docs: https://github.com/vacuumlabs/ledger-app-cardano-shelley/blob/develop/doc/ins_sign_tx.md so they don't fall out of sync |
Not 100% finished and needs some polishing.