Cardano Conway certificates #28
Open
+444
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaskp
force-pushed
the
feat/cardano-conway-certificates
branch
from
e6c0059
to
3fcb6f1
Compare
davidmisiak
reviewed
Dec 6, 2023
davidmisiak
reviewed
Dec 8, 2023
jaskp
force-pushed
the
feat/cardano-conway-certificates
branch
2 times, most recently
from
c6074b9
to
7c9fe02
Compare
davidmisiak
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Except for the naming that is being discussed, I haven't spotted any issue.
Can you please update the docs here though? (Sorry I haven't realized that earlier.)
janmazak
reviewed
Jan 9, 2024
janmazak
reviewed
Jan 11, 2024
The length isn't being validated in suite, just firmware |
jaskp
force-pushed
the
feat/cardano-conway-certificates
branch
from
fba08ee
to
2766de5
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ci/scripts/checkNpmAndLocal.js
Outdated
| process.chdir(outputDirectory); | ||
|
|
||
| // Run npm pack | ||
| const result = execSync(`npm pack ${modulePath}`, { encoding: 'utf8' }); |
Check warning
Code scanning / CodeQL
Shell command built from environment values
jaskp
force-pushed
the
feat/cardano-conway-certificates
branch
4 times, most recently
from
eb99401
to
28c615e
Compare
davidmisiak
approved these changes
Jan 18, 2024
davidmisiak
force-pushed
the
feat/cardano-conway-certificates
branch
from
28c615e
to
0d89e41
Compare
davidmisiak
force-pushed
the
feat/cardano-conway-certificates
branch
from
0d89e41
to
fd92a5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Resolve
Screenshots: