Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade peer dependency ink #72

Merged
merged 7 commits into from
Jun 6, 2024

Conversation

jlarmstrongiv
Copy link
Contributor

Closes #71

@jlarmstrongiv
Copy link
Contributor Author

I updated the PR to fix xo linting errors from updates to https://github.com/sindresorhus/eslint-plugin-unicorn 👍 triggering another workflow run would be great!

@sindresorhus
Copy link
Collaborator

CI is failing. Make sure npm test succeeds locally.

@jlarmstrongiv
Copy link
Contributor Author

jlarmstrongiv commented May 27, 2024

Not sure why, but I was only able to get ava to run tests by setting NODE_OPTIONS directly avajs/ava#2593 (comment)

Please try re-running the CI. While some tests were timing out due to my local environment, I am more confident the CI should pass.

@sindresorhus
Copy link
Collaborator

Ink 5 requires Node.js 18, so to support that, we also need to require it. Also update the Ink dev dependency so we can be sure it works.

@jlarmstrongiv
Copy link
Contributor Author

Alrighty, I originally thought it may be possible for pastel to support both ink v4 and v5, but I have changed it to require ink@5 and nodejs >=18 👍 tests still seem to pass, but you’ll need to run the workflow to confirm

Last but not least, as the minimum version of node has changed, I bumped pastel a major version to v3

@sindresorhus
Copy link
Collaborator

I bumped pastel a major version to v3

Don't make unrelated changes.

@sindresorhus sindresorhus merged commit c357d3d into vadimdemedes:main Jun 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade ink to v5 compatible
2 participants