Support full customization #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 25, 2020
|
@vadimdemedes Any idea when this is going to be merged and published? How can we help? Thanks! 😊 |
|
@eduludi Best help would be to test it in real apps and let me know whether you see any issues, like missing classes. Would appreciate it! |
|
@vadimdemedes so far, so good 👍 |
|
It's throwing a I installed the custom branch using the |
This was referenced Dec 23, 2020
vadimdemedes
force-pushed
the
custom-config
branch
from
6a4c9ba to
7d2e9c8
Compare
|
@aswinmohanme I just tried it out myself and it seems to work. Did you install this PR via |
|
I can confirm it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites how
tailwind-rnworks. Previously it specified an allow list of utilities (classes), which would strip out any custom properties from your config, like custom colors. This PR changes it to block unsupported utilities and CSS properties instead, while allowing everything else.