Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 cleanup of progress bar and tree #1771

Merged
merged 3 commits into from
Dec 16, 2021
Merged

Conversation

maartenbreddels
Copy link
Member

We now also report if it comes from cache or when an error occured.

Also moved out of utils.py to progress.py

@maartenbreddels
Copy link
Member Author

should be more stable now with rich, and we now also see with [1] and [2] which pass over the data it did for which task, here it takes.3 passes.
image

@maartenbreddels
Copy link
Member Author

Also, using the context manager, everything will be added to the progress tree:
image

We also/still support via progress=True/'rich'

@maartenbreddels
Copy link
Member Author

note that in this last example, we didn't use delay=True, causing it to do 4 passes, instead of 2. @JovanVeljanoski I think this can be a good addition to the docs, explaining how vaex works.

@maartenbreddels maartenbreddels merged commit 51e15fc into master Dec 16, 2021
@JovanVeljanoski JovanVeljanoski deleted the refactor_progress branch December 16, 2021 11:13
@maartenbreddels maartenbreddels restored the refactor_progress branch December 16, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant