Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐎🔨 large refactor of aggregator for better performance #1847

Merged
merged 4 commits into from
Jan 20, 2022
Merged

🐎🔨 large refactor of aggregator for better performance #1847

merged 4 commits into from
Jan 20, 2022

Conversation

maartenbreddels
Copy link
Member 

When thread > grids, we do the mutex locks at the C++/aggregator level
instead of the task part level, this means when we have multiple
aggregators, we can use the CPU more effectively.

@maartenbreddels
🔨 add experimental BinnerHash
57aa067 
this will be more cache friendly, since a tighter loop in c++
However, performance isn't great because expressions are always
evaluated with all threads enabled.
A future refactor may make better use of this.
@maartenbreddels
🐎🔨 large refactor of aggregator for better performance
e9733af 
When thread > grids, we do the mutex locks at the C++/aggregator level
instead of the task part level, this means when we have multiple
aggregators, we can use the CPU more effectively.
@maartenbreddels
add first agg
bd58303
@maartenbreddels
fixes
b36d151
@maartenbreddels maartenbreddels merged commit ee09761 into master Jan 20, 2022
@maartenbreddels maartenbreddels mentioned this pull request Jan 20, 2022
Merged
2 tasks
@jameslamb jameslamb mentioned this pull request Jun 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maartenbreddels