fix: don't release the gil to early #2440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why the error message is not that clear. |
maartenbreddels
force-pushed
the
fix_gil_release
branch
2 times, most recently
from
1c7994e to
11f5271
Compare
|
go, go, gooo! |
maartenbreddels
force-pushed
the
fix_gil_release
branch
from
11f5271 to
ebb83bb
Compare
|
Whow, super happy that this appears to be it. |
ddelange
approved these changes
Oct 8, 2024
ddelange
reviewed
Oct 8, 2024
maartenbreddels
force-pushed
the
fix_gil_release
branch
from
ebb83bb to
5244572
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only to check if we now catch the error in CI, the fix will come in a later commit.
See #2439