Skip to content
This repository has been archived by the owner on Jun 25, 2023. It is now read-only.

Read IP from guest even if there's just 1 private network #246

Closed
wants to merge 1 commit into from

Conversation

njam
Copy link
Contributor

@njam njam commented Aug 17, 2016

Fixes #268

In case we want to use the public network's address.

For example my box has a private and a public address:

    config.vm.network :private_network, ip: '10.10.11.10'
    config.vm.network :public_network, :bridge => 'en0: Wi-Fi (AirPort)'

And I want to use the public one with:

config.landrush.host_interface = 'eth2'

For this we will need to use read_host_visible_ip_address.

@hferentschik wdyt?

@njam njam self-assigned this Aug 17, 2016
In case we want to use the public network's address
@njam njam mentioned this pull request Aug 22, 2016
@njam
Copy link
Contributor Author

njam commented Sep 27, 2016

@hferentschik wdyt?

@hferentschik
Copy link
Contributor

So you want to skip the case in which the private network is automatically selected in case it is the sole private network, right? I guess this makes sense. I might have been a bit hasty when I added this "optimisation".

Do we have an actual issue for that and if not, do you mind creating one? At first glance this looks fine.

@njam
Copy link
Contributor Author

njam commented Sep 28, 2016

You mean to have a separate issue? Like this? #268

Good to merge?

@hferentschik
Copy link
Contributor

You mean to have a separate issue? Like this? #268

Perfect :-)

@hferentschik hferentschik added this to the v1.2.0 milestone Sep 29, 2016
@hferentschik hferentschik removed this from the v1.2.0 milestone Sep 29, 2016
@hferentschik
Copy link
Contributor

Good to merge?

Merged, thanks :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants