Resolve unzip error on applying new patches when composer cache is cleared

[adamj88]

Fixes #103

[adamj88]

@zamoroka would you be able to merge this PR, please?

It addresses a bug in the patch process detailed in #103 which is fairly common.

[ElSamhaa]

What is the status of this fix? I'm facing the bug for some time now.

[hostep]

Hi @zamoroka, have you guys already had some time to look into this?

We keep running into #103 from time to time. Re-running composer install a second time (or sometimes 3 or 4 times more) always fixes it, but it's annoying that this keeps happening every now and again.

I haven't verified if these changes fixes the problem, but I assume Adam tested this.

[zamoroka-vaimo]

Hi all, PR released in 5.1.2
sorry for the delay :)

[fredden]

This change seems related to #111, and #112 looks like it will revert at least part of this change. There doesn't seem to be any in-depth explanation for why this change is the correct thing to fix #103. Can @adamj88 provide some insight into the reasoning for this change, please?

[adamj88]

@fredden from #103 the explanation was that the uninstall method inside the promise was at fault:

If we replace it with the code

 $installationManager
            ->uninstall($repository, $uninstallOperation);

        return $installer
                ->download($package)
            ->then(function () use ($installationManager, $installOperation, $repository) {
                $installationManager->install($repository, $installOperation);
            });

the patches apply properly even when composer cache is cleared.
It looks like the promise is not working for the uninstall function, but I need more input here.

[hostep]

We also keep running into #111 after upgrading to 5.1.2, so it sounds like this fix causes more issues than it fixes, we have to downgrade to 5.1.1 to even get the module to work at all in certain cases unfortunately :(

@zamoroka-vaimo: would be appreciated if you find some more time to look into this a bit and if #112 would fix things or not...