-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use proper way to retrieve the Composer version #92
Conversation
@zamoroka while you're merging, can you do this one as well? :) |
Hi @Seldaek , @peterjaap |
Since 1.8.5 was released in april 2019 and Composer 1 is on it's way out, I'd be perfectly fine with that. |
@Seldaek could you please add the min composer version in composer.json?
|
There is no way to do this unfortunately as the plugin-api is stuck at 1.1.0 on Composer 1. Either we require From my stats I see 1-2% of installs coming from Composer versions older than 1.8.5 so I think it's fairly irrelevant, those are unlikely to be updating packages anyway.. |
@Seldaek I think adding
to the "require" section could do the trick |
Nope this is a bad idea as it'd add composer in the vendor dir, and not actually fix anything. Your options are what I said above, or if you want to absolutely support everything add a method_exists call before using getVersion? |
ok, let then go with |
Yeah I think this makes the most sense, anyone stuck on an old composer will then remain on the previous version of the plugin, no big deal. |
OK good to go then I think. |
Fixes #81