Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go to definition #8

Closed
tmcw opened this issue Nov 17, 2023 · 4 comments · Fixed by #46
Closed

Go to definition #8

tmcw opened this issue Nov 17, 2023 · 4 comments · Fixed by #46
Labels
enhancement New feature or request

Comments

@tmcw
Copy link
Member

tmcw commented Nov 17, 2023

CleanShot 2023-11-17 at 17 13 06@2x

Should already be possible given the data in the hint extension, but if people want to replicate this experience we should make that possible as well.

@tmcw tmcw added the enhancement New feature or request label Nov 17, 2023
@curran
Copy link

curran commented Dec 6, 2023

@curran
Copy link

curran commented Apr 24, 2024

@curran
Copy link

curran commented Apr 24, 2024

The interaction in VSCode:

  • Hold CTRL
  • Hover on a variable, it underlines if you can jump to its definition
  • CTRL+Click to jump to definition

@tmcw
Copy link
Member Author

tmcw commented Apr 24, 2024

That's in the typescript-language-server project, which is a 3rd party adapter from the TypeScript interface to the LSP interface, because TypeScript doesn't actually implement LSP (which is a thing I rant about all the time, Microsoft get your act together, etc). This module currently uses TypeScript, but not the extra language server. It'd probably use the language server if this adopted more of a client-server architecture, or maybe it should in general, but for now, it's integrating with TypeScript, and we'll need to figure out what's under the hood of the LSP adapter's implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants