Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode-ish: Jump to Definition of Variable #177

Closed
curran opened this issue Sep 19, 2023 · 5 comments · Fixed by #717
Closed

VSCode-ish: Jump to Definition of Variable #177

curran opened this issue Sep 19, 2023 · 5 comments · Fixed by #717
Assignees

Comments

@curran
Copy link
Contributor

curran commented Sep 19, 2023

As a user of VZCode, I want to be able to hold CTRL and click on a variable name to jump to the definition of that variable, just like I can in VSCode.

@curran curran moved this to November in VZCode Kanban Sep 19, 2023
@curran curran changed the title CTRL+Click to jump to definition Jump to Definition of Variable Sep 23, 2023
@curran curran changed the title Jump to Definition of Variable VSCode-ish: Jump to Definition of Variable Sep 23, 2023
@servesh-chaturvedi
Copy link

Hi Curran, really love your work and videos. I wanted to understand if there is any particular reason for preferring codemirror to monaco editor. It closely resembles the VSCode experience and also feature-rich so less things to implement.

@curran
Copy link
Contributor Author

curran commented Sep 25, 2023

The main reason is that when I looked into Monaco, it just really felt quite bloated and cumbersome. I had been following CodeMirror 6 developments for some time (see this early piece: CodeMirror 6 Experiments), and am deeply aligned with Marjin's development approach and goals, especially around the plugin architecture and the mobile usability. I've read that Monaco does not work on mobile, which for me is a deal breaker as one of my ultimate goals is to make a code editor that is actually somewhat usable on mobile, for folks who want to learn to code but don't have access to a laptop (like folks in India - there are many people like this).

I also have a history of working with CodeMirror 5 + ShareDB for the real-time integration, and was able to "unlock" that CodeMirror 6 + ShareDB integration successfully, which took a ton of work. So even if Monaco is great, there's the sunk cost of that integration that's already behind me. Doing a similar integration with Monaco + ShareDB seems like a scary huge task that may turn out to be impossible.

This post captures many of the pain points I see with Monaco in general: https://about.sourcegraph.com/blog/migrating-monaco-codemirror

image

Thanks for the question!

@curran curran moved this from November to December in VZCode Kanban Oct 20, 2023
@jlewenthal2004 jlewenthal2004 self-assigned this Nov 4, 2023
@curran curran moved this to Backlog in VZCode Kanban Dec 6, 2023
@curran curran moved this from Backlog to Up Next in VZCode Kanban Apr 23, 2024
@curran
Copy link
Contributor Author

curran commented Apr 23, 2024

This is the single most valuable feature of VSCode that I really miss when using VZCode.
We are already using the TypeScript language server, which may have this sort of functionality built in.
Needs some research on existing implementations with CodeMirror 6.
There's a chance someone has already figured this out in the open source world somewhere.

@curran
Copy link
Contributor Author

curran commented Apr 23, 2024

In VSCode it's CTRL+Hover, then click which navigates to the definition.

@jeffrey-cordero jeffrey-cordero self-assigned this May 31, 2024
@jeffrey-cordero jeffrey-cordero linked a pull request Jun 7, 2024 that will close this issue
@jeffrey-cordero jeffrey-cordero moved this from Up Next to In Progress in VZCode Kanban Jun 10, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in VZCode Kanban Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants