tests: Run tests with G_DEBUG=fatal-warnings #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricotz
force-pushed
the
wip/ricotz/fail
branch
from
5ee14d5
to
dd15295
Compare
|
@kgrubb Did you give it some thoughts? |
|
@kgrubb It is not strictly about the changes, but the way the test-suite works. Manually creating Vala symbols might be too error prone. And using actual code-snippets would be better. That way a proper Vala AST can be used. |
|
@ricotz Is there a direct way to parse only a string, but not a complete Vala-sourcefile? |
|
@pantor no, currently not |
|
I've moved all unit tests to file tests, so we don't create Vala symbols manually anymore. |
pantor
previously approved these changes
May 4, 2020
|
@pantor Please fix these warnings. $ _build/src/io.elementary.vala-lint
.test/FileTest.vala
38.120 warn Line exceeds limit of 120 characters (currently 129 characters) line-length
53.120 warn Line exceeds limit of 120 characters (currently 151 characters) line-length
56.120 warn Line exceeds limit of 120 characters (currently 155 characters) line-length
64.120 warn Line exceeds limit of 120 characters (currently 154 characters) line-length
67.120 warn Line exceeds limit of 120 characters (currently 151 characters) line-length
70.120 warn Line exceeds limit of 120 characters (currently 169 characters) line-length
73.120 warn Line exceeds limit of 120 characters (currently 163 characters) line-length
76.120 warn Line exceeds limit of 120 characters (currently 154 characters) line-length |
|
Warnings should be all fixed now. |
kgrubb
approved these changes
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.