New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes #4

Merged

shenoynikhil merged 2 commits into main from minor-fixes

Sep 26, 2023

Collaborator

shenoynikhil commented Sep 26, 2023 •

edited

Loading

Changes:

Spell error from get_atomic_numuber_and_charge to get_atomic_number_and_charge
Updated overwrite=True to False to avoid overwriting pre-processed files.
Update base to return np.array instead of np.memmap

Checklist:

Was this PR discussed in a issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
Update the API documentation is a new function is added or an existing one is deleted.

shenoynikhil added 2 commits

September 25, 2023 18:50


          Updated naming of get_atomic_number

bd2e008


          Updated base to return np.array instead of memmap

77f1efe

shenoynikhil requested a review from prtos as a code owner

September 26, 2023 18:45

shenoynikhil merged commit 5ec94bd into main

shenoynikhil deleted the minor-fixes branch

September 27, 2023 17:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet