Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default fields for all entities in extractor #571

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Add default fields for all entities in extractor #571

wants to merge 12 commits into from

Conversation

SelfMadeSystem
Copy link
Contributor

@SelfMadeSystem SelfMadeSystem commented Oct 19, 2023 •
edited
Loading

Objective

Solution

  • Get the defaults of every entity and use them
  • Remove defaults for individual fields
  • Sort everything by id

@SelfMadeSystem

This comment was marked as outdated.

Sign in to view
@SelfMadeSystem
Copy link
Contributor Author

perhaps not as crazy as I initially thought

@SelfMadeSystem SelfMadeSystem marked this pull request as draft October 21, 2023 01:54
@SelfMadeSystem SelfMadeSystem marked this pull request as ready for review October 21, 2023 16:08
rj00a
rj00a reviewed Oct 24, 2023
View reviewed changes
Copy link
Member

@rj00a rj00a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

I suspect bevy is not going to be happy about the huge number of systems being scheduled now. Each system has some constant overhead, especially with the multithreaded executor. You could try merging the systems together, but this is one problem I'm trying to address with my new ECS library.

crates/valence_entity/build.rs Outdated Show resolved Hide resolved
crates/valence_entity/build.rs Outdated Show resolved Hide resolved
crates/valence_entity/build.rs Outdated Show resolved Hide resolved
@SelfMadeSystem SelfMadeSystem marked this pull request as draft October 24, 2023 17:28
@SelfMadeSystem SelfMadeSystem marked this pull request as ready for review October 25, 2023 19:16
@SelfMadeSystem SelfMadeSystem requested a review from rj00a October 25, 2023 19:16
@rj00a rj00a mentioned this pull request Jan 29, 2024
Open
rj00a added a commit that referenced this pull request Feb 16, 2024
@rj00a @SelfMadeSystem
Rewrite entity extractor
ad3186b 
Fixed some bugs and added proper default values for fields. Partially
adapted from #571.

Co-authored-by: SelfMadeSystem <sms@shoghisimon.cc>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rj00a rj00a Awaiting requested review from rj00a

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SelfMadeSystem @rj00a