Introduce slugifyWithState
to avoid breaking change with slugify
second argument
#134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#125 is a good suggestion but I'm worried some users pass directly some slugification modules as
slugify
argument e.g. one could do:And
@sindresorhus/slugify
takes an optional options object as second argument. Addingstate
as second argument would break that.While it's not the way I recommend using it (the readme specifies doing
{ slugify: s => slugify(s) }
), I'd rather avoid risking a breaking change.So this refactors #125 to 1. pass the whole
state
instead ofstate.env
so people can do whatever they want with the whole thing, and 2. put this in aslugifyWithState
option to avoid a potential breaking change.