Change markdown-it dependency to * and add types
#76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
mrdrogdrog
changed the title
*
2 tasks
mrdrogdrog
changed the title
** and add types
|
@mrdrogdrog, thank you |
This was referenced Mar 8, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm one of the devs from https://github.com/hedgedoc/react-client. We use your package, but are having some problems, because this package still depends on markdown-it v10. It confused our typescript setup because it tries to resolve the v10 types, but we use markdown-it v12 (which is the current version of markdown it.)
Therefore this PR bumps the markdown-it dependency to
*(because it's only needed for tests).Please merge it soon and release a new version :)
EDIT:
I also added the typescript types from @types/markdown-it-anchor