Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

189 trino supporting more variables for securitycontext for pod and container level #190

Conversation

valeriano-manassero
Copy link
Owner

What this PR does / why we need it:

More detailed securityContexts.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Verify the work you plan to merge addresses an existing issue (If not, open a new one) (required)
  • Check your branch with helm lint (required)
  • Update version in Chart.yaml according semver rules (required)
  • Substitute annotations section in Chart.yaml annotating implementations (useful for Artifacthub changelog) (required)
  • Update chart README using helm-docs (required)

Which issue(s) this PR fixes:

Fixes #189

Special notes for your reviewer:

None

@hafizmujadidKhalid
Copy link
Contributor

@valeriano-manassero!
I think containerSecurityContext is missing in Coordinator container:

@valeriano-manassero
Copy link
Owner Author

@valeriano-manassero! I think containerSecurityContext is missing in Coordinator container:

I added it, can you pls check if we are good now?

@hafizmujadidKhalid
Copy link
Contributor

@valeriano-manassero!

It works like a charm. Thanks

@valeriano-manassero valeriano-manassero merged commit 2129571 into main Oct 25, 2023
5 checks passed
@valeriano-manassero valeriano-manassero deleted the 189-trino-supporting-more-variables-for-securitycontext-for-pod-and-container-level branch October 25, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[trino] Supporting more variables for securityContext for pod and container level.
2 participants