Fix for OpenCV 4.2 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest OpenCV on Anaconda is 4.2, and some flags like `cv::CV_COVAR_ROWS` flag have become `cv::COVAR_ROWS`
|
Thanks! Much appreciated. I was wondering whether the code works with OpenCV versions other than the 3.2 one from Ubuntu 18.04 I was using, but did not get around to testing it yet. I'm planning to add some version support tests for OpenCV, CMake and Python via GitHub's CI soon. I sort of did create a PR for this repo here, but have received no response so far: JiaxiongQ/DeepLiDAR#31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest OpenCV on Anaconda is 4.2, and some flags like
cv::CV_COVAR_ROWSflag have becomecv::COVAR_ROWS(so it doesn't compile anymore)Have you thought about making a pull request for the original repo? It might make your updated code more visible