add back whitelisting and unit tests for it #2545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinkreiser
commented
Aug 20, 2020
| @@ -327,27 +330,17 @@ const std::vector<std::pair<uint16_t, std::string>> osrm_responses{ | |||
| {400, | |||
| R"({"code":"InvalidValue","message":"The successfully parsed query parameters are invalid."})"}}; | |||
|
|
|||
| zmq::context_t context; | |||
There was a problem hiding this comment.
the diff looks odd here because i pulled the configuration making out into its own function. this part of the test and the tests that rely on it didnt change
kevinkreiser
commented
Aug 20, 2020
| @@ -428,7 +440,37 @@ TEST(LokiService, test_osrm_failure_requests) { | |||
| run_requests(osrm_requests, osrm_responses); | |||
| } | |||
|
|
|||
| // todo: test_success_requests?? | |||
| TEST(LokiService, test_actions_whitelist) { | |||
There was a problem hiding this comment.
this is the only real change to the test, a new test that checks getting rejected and checks getting accepted for all actions
danpaz
approved these changes
Aug 20, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
long ago we accidentally removed the action whitelisting functionality from the code. this puts it back and adds unit tests for it.
reference: 1175a5a#diff-571fae4697ac934f38db80af7b71d54dL69