Change treatment of pencil point u-turns to ignore situations where two unnamed roads form the pencil-point #3084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when the turn transitions between two unnamed roads. It now checks to see if the connected edges are named before checking for name consistency.
gknisely
requested changes
May 19, 2021
There was a problem hiding this comment.
@kshehadeh looks good but we should add a gurka test to this one and you need to update the changelog.
|
@kshehadeh nice catch! |
gknisely
previously approved these changes
May 19, 2021
|
|
||
| int maneuver_index = 1; | ||
|
|
||
| // Verify the left uturn instructions |
There was a problem hiding this comment.
The comment says to expect a uturn but the instructions is a sharp left. Also how is this case different than the last one? They seem similar.
mandeepsandhu
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a problem where the pencil-point u-turn logic is triggered even when the turn transitions between two unnamed roads. It now checks to see if the connected edges are named before checking for name consistency.
Issue
There are situations where a pencil point u-turn is identified when it shouldn't be. In these cases, a u-turn is formed from two unnamed roads but the two roads are treated as the same road. They shouldn't be.
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?