Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle list arguments with nargs instead of list type when overriding… #4799

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Handle list arguments with nargs instead of list type when overriding… #4799

merged 3 commits into from
Jul 12, 2024

Conversation

asmyth01
Copy link
Contributor

@asmyth01 asmyth01 commented Jul 12, 2024 •
edited by kevinkreiser
Loading

Issue

fixes #4798

Tasklist

  • Add tests
  • Add #fixes with the issue number that this PR addresses
  • Update the docs with any new request parameters or changes to behavior described
  • Update the changelog
  • If you made changes to the lua files, update the taginfo too.

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

kevinkreiser
kevinkreiser reviewed Jul 12, 2024
View reviewed changes
@kevinkreiser
Copy link
Member

thank you for this cleanup!

@kevinkreiser kevinkreiser merged commit bfc3460 into valhalla:master Jul 12, 2024
7 checks passed
ADMUKHE pushed a commit to mercedes-benz/valhalla that referenced this pull request Jul 28, 2024
@asmyth01
Handle list arguments with nargs instead of list type when overriding… (
6e6c0c4 
valhalla#4799)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinkreiser kevinkreiser kevinkreiser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

valhalla_config_build does not handle list arguments correctly
2 participants
@asmyth01 @kevinkreiser