Exclude executables from coverage #5042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
and yet coverage is reduced somehow? |
|
What hahah how? Zu früh gefreut |
|
scheint so ja.. when i look at the report it still says there are tracked lines in those files: https://app.codecov.io/gh/valhalla/valhalla/tree/cb-coverage/src so maybe we just have the flag to do the exclusions wrong? i saw you put multiple on the same argument maybe you have to specify the flag multiple times, once for each exclude? |
kevinkreiser
reviewed
Jan 8, 2025
CMakeLists.txt
Outdated
| @@ -360,7 +360,7 @@ if(ENABLE_COVERAGE) | |||
|
|
|||
| set(FASTCOV_PATH ${VALHALLA_SOURCE_DIR}/third_party/fastcov/fastcov.py) | |||
| add_custom_command(OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/coverage.info | |||
| COMMAND ${FASTCOV_PATH} -d . --exclude /usr/ third_party/ ${CMAKE_CURRENT_BINARY_DIR}/ --lcov -o coverage.info | |||
| COMMAND ${FASTCOV_PATH} -d . --exclude /usr/ third_party/ src/valhalla_ src/mjolnir/valhalla_ ${CMAKE_CURRENT_BINARY_DIR}/ --lcov -o coverage.info | |||
There was a problem hiding this comment.
maybe for things that arent directories you need wildcards or something..
|
i noticed the coverage still doesnt quite agree so there is still more to update here |
ianthetechie
pushed a commit
to ianthetechie/valhalla
that referenced
this pull request
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
fastcovuses substring matching to exclude files, so passingsrc/valhalla_andsrc/mjolnir/valhalla_should do the trick. Tested locally and worked as expected.