Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update image validator to only consider "synced" images #113

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

arturshadnik
Copy link
Member

Issue

Resolves #97

Description

  • Adding a check to make sure only "Synced" images are considered for validation
  • Updating DNSResource to use the updated maas API client
  • Bumping base Go versions for Docker images
  • Making maas API error handling more consistent

chore: bump go version in dockerfiles

style: make api error handling more consistent

refactor: update with new changes in gomaasclient
@arturshadnik arturshadnik requested a review from a team as a code owner August 1, 2024 00:03
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement Enhancement to an existing feature labels Aug 1, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Files Patch % Lines
internal/validators/os/os_validator.go 80.00% 1 Missing and 1 partial ⚠️
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
+ Coverage   75.50%   75.64%   +0.14%     
==========================================
  Files           8        8              
  Lines         347      349       +2     
==========================================
+ Hits          262      264       +2     
  Misses         69       69              
  Partials       16       16              
Files Coverage Δ
internal/validators/dns/internal_dns_validator.go 95.65% <100.00%> (ø)
internal/validators/dns/upstream_dns_validator.go 92.30% <100.00%> (ø)
internal/validators/os/os_validator.go 94.44% <80.00%> (+0.32%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c7b757...12138fb. Read the comment docs.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 1, 2024
@arturshadnik arturshadnik merged commit 8f62d0c into main Aug 1, 2024
8 checks passed
@arturshadnik arturshadnik deleted the enh/image branch August 1, 2024 02:29
TylerGillson added a commit that referenced this pull request Aug 1, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.0.6](v0.0.5...v0.0.6)
(2024-08-01)


### Features

* implement internal dns rules validation
([#111](#111))
([6c7b757](6c7b757))
* implement resource rules validation
([#105](#105))
([1b428e1](1b428e1))


### Dependency Updates

* **deps:** update module github.com/onsi/gomega to v1.34.1
([02600b9](02600b9))
* **deps:** update module github.com/validator-labs/validator to v0.0.50
([ae3eb42](ae3eb42))
* **deps:** update module github.com/validator-labs/validator to v0.0.51
([3a30e35](3a30e35))


### Refactoring

* update image validator to only consider "synced" images
([#113](#113))
([8f62d0c](8f62d0c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing feature lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ OS Image Validation
2 participants