Refactor code #52
Merged
Refactor code #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
commented
Sep 7, 2021
| if (key === 'format' && value !== 'gnu') { | ||
| vnuArgs = [...vnuArgs, `--format ${value}`]; | ||
| vnuArgs.push('--format', value); |
There was a problem hiding this comment.
Wasn't this wrong before? It triggers a new unsafe shell command error. Any ideas how to fix this welcome.
There was a problem hiding this comment.
I pushed a patch which limits the format values, let me know what you think
XhmikosR
force-pushed
the
dev
branch
4 times, most recently
from
a093afd to
44dce90
Compare
XhmikosR
force-pushed
the
dev
branch
3 times, most recently
from
4161eb3 to
c32232b
Compare
XhmikosR
force-pushed
the
dev
branch
4 times, most recently
from
6b43aa9 to
3572fce
Compare
* use `Array.push` instead of spread * quote paths so that they work with folders with spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@watilde could you have a quick look please?
Note that things should work now when there are spaces in the
vnu-jarpath too. I also removedvnuErrorLevels.colorsbecause AFAICT they do nothing if you do not pass them to winston.