This repository has been archived by the owner on Apr 27, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parasg1999
suggested changes
May 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great if you could remove assertString
, we don't need that in Typescript. Also please make sure you put the content in alphabetic order in mod.ts
and test.ts
.
parasg1999
added
enhancement
New feature or request
🧹 needs-update
For PRs that need to be updated before landing
labels
May 28, 2020
@parasg1999 I made the changes you asked for. Take a look. |
parasg1999
approved these changes
May 28, 2020
LGTM. Will request @rubiin to view it. |
parasg1999
added
needs more review
and removed
🧹 needs-update
For PRs that need to be updated before landing
labels
May 28, 2020
@RishabAgarwal fix the merge conflicts |
the tests are failing . please ensure everything works before push @RishabAgarwal |
@rubiin ya sorry about that... |
looks good LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.