Skip to content
This repository has been archived by the owner on Apr 27, 2024. It is now read-only.

Added isDivisibleBy #21

Merged
merged 6 commits into from
May 29, 2020
Merged

Added isDivisibleBy #21

merged 6 commits into from
May 29, 2020

Conversation

RishabAgarwal
Copy link

No description provided.

@RishabAgarwal RishabAgarwal changed the title Added isDivisiblebY Added isDivisibleBy May 28, 2020
Copy link
Collaborator

@parasg1999 parasg1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if you could remove assertString, we don't need that in Typescript. Also please make sure you put the content in alphabetic order in mod.ts and test.ts.

@parasg1999 parasg1999 added enhancement New feature or request 🧹 needs-update For PRs that need to be updated before landing labels May 28, 2020
@RishabAgarwal
Copy link
Author

@parasg1999 I made the changes you asked for. Take a look.

@parasg1999
Copy link
Collaborator

LGTM. Will request @rubiin to view it.

@parasg1999 parasg1999 added needs more review and removed 🧹 needs-update For PRs that need to be updated before landing labels May 28, 2020
@rubiin rubiin mentioned this pull request May 28, 2020
68 tasks
@rubiin
Copy link
Member

rubiin commented May 29, 2020

@RishabAgarwal fix the merge conflicts

@rubiin
Copy link
Member

rubiin commented May 29, 2020

the tests are failing . please ensure everything works before push @RishabAgarwal

@RishabAgarwal
Copy link
Author

@rubiin ya sorry about that...

@rubiin
Copy link
Member

rubiin commented May 29, 2020

looks good LGTM

@rubiin rubiin merged commit 1dc75f4 into validatorjs:master May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request needs more review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants