-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validator 13.5.1 doesn't support 163/126 format email #1543
Comments
We're also seeing this issue-- emails where the domain name is just numbers are now considered invalid. |
Here's the problem I think: https://github.com/validatorjs/validator.js/pull/1474/files#diff-3b6763f98d8f87da73f519e2f3e4c0adea82d001683f51e1c7beba87f6782b0eR37 @CristhianMotoche is not testing the TLD because it was |
@CristhianMotoche -- can look into this? |
Hi! I'll try to take a look at it later today. |
Cool, thanks! |
I'm sorry, but I haven't had the time to check this. 😞 |
No worries, it's alright. |
Hi! I was checking the issues and PRs and I think I'm late to fix this. It seems PR #1546 will address this and some additional fixes for |
Sorry @CristhianMotoche i didn't see this issue and that you were assigned to fix it 😅 |
No worries. Actually, thanks for solving it. 😄 |
Fixed in #1546 -- will release this patch as a hotfix due to the regression. |
Describe the bug
A clear and concise description of what the bug is.
validator 13.5.1 doesn't support 163/126 format email such as hello@163.com or hello@126.com
163/126 is Netease email service。It is very popular in China
validator 13.1.1 can support 163/126
Examples
If applicable, add screenshots to help explain your problem.
code: validator_mail.js
13.5.1 test case:
13.1.1 test case:
Additional context
Validator.js version: 13.5.1
Node.js version:v11.2.0
OS platform: [windows, linux, macOS, etc] linux Ubuntu 18.04.1 LTS
The text was updated successfully, but these errors were encountered: