-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add fr-CA locale #1511
feat: Add fr-CA locale #1511
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,6 +9,7 @@ export const alpha = { | |
'es-ES': /^[A-ZÁÉÍÑÓÚÜ]+$/i, | ||
'fa-IR': /^[ابپتثجچحخدذرزژسشصضطظعغفقکگلمنوهی]+$/i, | ||
'fr-FR': /^[A-ZÀÂÆÇÉÈÊËÏÎÔŒÙÛÜŸ]+$/i, | ||
'fr-CA': /^[A-ZÀÂÆÇÉÈÊËÏÎÔŒÙÛÜŸ]+$/i, | ||
'it-IT': /^[A-ZÀÉÈÌÎÓÒÙ]+$/i, | ||
'nb-NO': /^[A-ZÆØÅ]+$/i, | ||
'nl-NL': /^[A-ZÁÉËÏÓÖÜÚ]+$/i, | ||
|
@@ -42,6 +43,7 @@ export const alphanumeric = { | |
'el-GR': /^[0-9Α-ω]+$/i, | ||
'es-ES': /^[0-9A-ZÁÉÍÑÓÚÜ]+$/i, | ||
'fr-FR': /^[0-9A-ZÀÂÆÇÉÈÊËÏÎÔŒÙÛÜŸ]+$/i, | ||
'fr-CA': /^[0-9A-ZÀÂÆÇÉÈÊËÏÎÔŒÙÛÜŸ]+$/i, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here, doing There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Of course² |
||
'it-IT': /^[0-9A-ZÀÉÈÌÎÓÒÙ]+$/i, | ||
'hu-HU': /^[0-9A-ZÁÉÍÓÖŐÚÜŰ]+$/i, | ||
'nb-NO': /^[0-9A-ZÆØÅ]+$/i, | ||
|
@@ -106,7 +108,7 @@ for (let locale, i = 0; i < farsiLocales.length; i++) { | |
} | ||
|
||
// Source: https://en.wikipedia.org/wiki/Decimal_mark | ||
export const dotDecimal = ['ar-EG', 'ar-LB', 'ar-LY']; | ||
export const dotDecimal = ['ar-EG', 'ar-LB', 'ar-LY', 'fr-CA']; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. According to many sources (even the link in the code comment) francophone area of Canada (fr-CA) are using decimal comma separator. Can you check this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Your're right I made a mistake. I'm in Quebec (canada-french) and most people i work with hate decimals for numbers. I was sure we had the same standard as English. So yes, in french this is the |
||
export const commaDecimal = [ | ||
'bg-BG', 'cs-CZ', 'da-DK', 'de-DE', 'el-GR', 'en-ZM', 'es-ES', 'fr-FR', 'it-IT', 'ku-IQ', 'hu-HU', 'nb-NO', | ||
'nn-NO', 'nl-NL', 'pl-PL', 'pt-PT', 'ru-RU', 'sl-SI', 'sr-RS@latin', | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it's the same regex for
fr-FR
andfr-CA
may be we should just assign the value like it was done forpt-BR
and all arabic localesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course.