-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(isUrl): higher priority to whitelist #1748
feat(isUrl): higher priority to whitelist #1748
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1748 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 102
Lines 2015 2029 +14
Branches 454 457 +3
=========================================
+ Hits 2015 2029 +14
Continue to review full report at Codecov.
|
@tux-tn please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
Thank you @deepanshu2506 for your PR ! Please address my comment and we should be good to go 👍
Is your contribution related to hacktoberfest ?
package.json
Outdated
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you revert your changes to package.json, i guess your code editor added a new line here !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'll make the changes and yes my contribution is related to hacktoberfest
yes my contribution related to hacktoberfest |
@tux-tn I have addressed the required changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Thank you for your PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contrib!
This reverts commit 13651ea. reverted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A whitelist shouldn't be exclusive like this.
if (options.host_whitelist && checkHost(host, options.host_whitelist)) {
return true;
}
is probably more what we want here.
Happy to open a PR if wanted.
check the whitelist before checking if URL is a IP or FQDN.
resolves #1731
Checklist