Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): add missing options synthax on isISO8601 validator #1860

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

leonardovillela
Copy link
Contributor

This PR update the README.md docs to include the missing options optional parameter on isISO8601 validator.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #1860 (a97d726) into master (47ee5ad) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1860   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2059      2059           
  Branches       464       464           
=========================================
  Hits          2059      2059           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47ee5ad...a97d726. Read the comment docs.

Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 Thank you for your PR @leonardovillela

@tux-tn tux-tn added ready-to-land For PRs that are reviewed and ready to be landed 🎉 first-pr labels Nov 8, 2021
@leonardovillela
Copy link
Contributor Author

leonardovillela commented Nov 8, 2021

Thank you very much, I'm happy to contribute (even though is a small change).

Can you send me more issues to work? :)

@tux-tn
Copy link
Member

tux-tn commented Nov 8, 2021

Thank you for your enthusiasm and interest in this project!
Feel free to contribute by adding a missing locale in one of our validators (See #1761 as an example) or fix an open issue if nobody has not already opened a PR for it.

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contrib! 🎉

@profnandaa profnandaa merged commit 667b0bf into validatorjs:master Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 first-pr ready-to-land For PRs that are reviewed and ready to be landed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants