-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(isTaxID): Canadian Social Insurance Number (SIN) validator #1867
feat(isTaxID): Canadian Social Insurance Number (SIN) validator #1867
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1867 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 102
Lines 2059 2084 +25
Branches 464 472 +8
=========================================
+ Hits 2059 2084 +25
Continue to review full report at Codecov.
|
Thank you for your PR. Isn't SIN a Tax ID for individuals and thereby should be part of |
That is a good question. Actually I don't know. Let me ask my Canadian friends and google to clarify that. |
Okay, I have got an answer below
So, I have redone my work. I hope it's good to go now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM 🎉
Thank you for your PR! Can you just address my comment below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Thank you for your contribution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thanks for your contribution! 🎉
Here I have implemented separate validator to verify that an input is a valid SIN (Social Insurance Number in Canada).
I realised that you use a combination of ISO 639-1 + ISO 3166-1 alpha-2 to identify locale in the
isTaxID
validator, so I have applied appropriate two locales for the Canada -en-CA
andfr-CA
.Also I have added a few additional values of postal codes in Ukraine, Poland and Canada to improve autotesting isPostalCode validator.
Checklist