Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add country benin #1997

Merged
merged 6 commits into from
Jul 18, 2022
Merged

Feature/add country benin #1997

merged 6 commits into from
Jul 18, 2022

Conversation

rksp25
Copy link
Contributor

@rksp25 rksp25 commented Jul 5, 2022

Added regex for Benin fr-BJ

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@rksp25 rksp25 mentioned this pull request Jul 5, 2022
Open
@rksp25 rksp25 mentioned this pull request Jul 5, 2022
Merged
3 tasks
@rksp25
Copy link
Contributor Author

rksp25 commented Jul 7, 2022

@profnandaa Can you please review this PR!!

rubiin
rubiin requested changes Jul 17, 2022
View reviewed changes
Copy link
Member

@rubiin rubiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you have to fix merge conflicts before we can merge

@codecov
Copy link

codecov bot commented Jul 17, 2022 •
edited
Loading

Codecov Report

Merging #1997 (625603d) into master (518a663) will not change coverage.
The diff coverage is n/a.

❗ Current head 625603d differs from pull request most recent head 4096915. Consider uploading reports for the commit 4096915 to get more accurate results

@@            Coverage Diff            @@
##            master     #1997   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          104       104           
  Lines         2120      2108   -12     
  Branches       475       475           
=========================================
- Hits          2120      2108   -12
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)
src/lib/isIP.js 100.00% <0.00%> (ø)
src/lib/isLength.js 100.00% <0.00%> (ø)
src/lib/isLicensePlate.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 518a663...4096915. Read the comment docs.

@rksp25
Copy link
Contributor Author

rksp25 commented Jul 17, 2022

@rubiin conflict fixed please review

@rksp25
Copy link
Contributor Author

rksp25 commented Jul 17, 2022

Looks like you have to fix merge conflicts before we can merge

@rubiin conflict fixed please review

@rksp25 rksp25 requested a review from rubiin July 17, 2022 19:58
rubiin
rubiin previously approved these changes Jul 18, 2022
View reviewed changes
@rubiin rubiin added the mc-to-land Just merge-conflict standing between the PR and landing. label Jul 18, 2022
@rubiin
Copy link
Member

rubiin commented Jul 18, 2022

@rksp25 still says conflict. Rest is ok

@rubiin rubiin merged commit a17421a into validatorjs:master Jul 18, 2022
@rubiin
Copy link
Member

rubiin commented Jul 18, 2022

Thankyou for the contribution 🎉

@profnandaa profnandaa mentioned this pull request Feb 2, 2023
Closed
@rntvicente rntvicente mentioned this pull request May 24, 2024
Open
@sahilpawar58 sahilpawar58 mentioned this pull request May 25, 2024
Open
@ChinmoyHembram ChinmoyHembram mentioned this pull request May 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubiin rubiin rubiin approved these changes

Assignees
No one assigned
Labels
mc-to-land Just merge-conflict standing between the PR and landing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rksp25 @rubiin