Skip to content

Conversation

@DeepankRx
Copy link

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Base: 100.00% // Head: 99.77% // Decreases project coverage by -0.22% ⚠️

Coverage data is based on head (b69acbb) compared to base (86a07ba).
Patch coverage: 16.66% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##            master    #2060      +/-   ##
===========================================
- Coverage   100.00%   99.77%   -0.23%     
===========================================
  Files          104      105       +1     
  Lines         2203     2209       +6     
  Branches       477      478       +1     
===========================================
+ Hits          2203     2204       +1     
- Misses           0        5       +5     
Impacted Files Coverage Δ
src/lib/isEmoji.js 0.00% <0.00%> (ø)
src/index.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@WikiRik
Copy link
Member

WikiRik commented Oct 10, 2022

Various isEmoji PRs have been opened already, please look at them first. I think the most recent attempt is #2015 which can benefit from reviews

Copy link
Member

@rubiin rubiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants