-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(isBtcAddress): get rid of unnecessary if statement and comment #2132
refactor(isBtcAddress): get rid of unnecessary if statement and comment #2132
Conversation
* there is no need to do a check before, which RegExp use * refactored version also is bit faster as well, according to Benchmark.js tests I did
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2132 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 104 104
Lines 2308 2306 -2
Branches 578 578
=========================================
- Hits 2308 2306 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch!
Checklist
[ ] README updated (where applicable)[ ] Tests written (where applicable)