-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(isMobilePhone): added Virgin Mobile provider to (ar-KW). #2138
Conversation
…ation (ar-KW) Added Virgin Mobile provider range (41XXXXXX) to ar-KW. **References**: - [Virgin Mobile Kuwait Official Website FAQ](https://www.virginmobile.com.kw/en/faq/the-available-numbers-all-start-with-410-411-will-a-new-range-of-numbers-be-available-soon/)
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2138 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 104 104
Lines 2308 2308
Branches 578 578
=========================================
Hits 2308 2308
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm, this provider exist in Kuwait. I tested the validator and it seems to work properly for the new provider. The range 41 however might be expanded later to include other variations like 42 / 43 / etc.. but until then this validator is working as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm with https://www.itu.int/dms_pub/itu-t/oth/02/02/T02020000730012PDFE.pdf that this is correct
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contrib! 🎉
Added Virgin Mobile provider range (41XXXXXX) to ar-KW.
References:
Checklist