Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(isPort): Invalid leading zeros (#2208) #2211

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

anasshakil
Copy link
Contributor

@anasshakil anasshakil commented Mar 30, 2023

  • Fix leading zeros.
  • Test case updated.
const isValidPort = isPort('0001'); // false

closes #2208

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (9ba1735) to head (fcbe17a).
Report is 18 commits behind head on master.

❗ Current head fcbe17a differs from pull request most recent head 83ae52c. Consider uploading reports for the commit 83ae52c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2211   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         107      107           
  Lines        2405     2405           
  Branches      604      604           
=======================================
  Hits         2404     2404           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@profnandaa profnandaa merged commit b34a335 into validatorjs:master Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ports starting with multiple zeros pass the verification
3 participants