Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isMobilePhone): update phone regex for Ghana en-GH #2362

Merged

Conversation

NanaAb-116
Copy link
Contributor

@NanaAb-116 NanaAb-116 commented Jan 22, 2024

added phoneNumber regex for MTN Ghana phone numbers tarting with 53

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

Copy link
Member

@ezkemboi ezkemboi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left comment, please add tests

src/lib/isMobilePhone.js Show resolved Hide resolved
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b958bd7) 99.95% compared to head (2f74f5c) 99.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2362      +/-   ##
==========================================
- Coverage   99.95%   99.95%   -0.01%     
==========================================
  Files         107      107              
  Lines        2454     2449       -5     
  Branches      619      619              
==========================================
- Hits         2453     2448       -5     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NanaAb-116
Copy link
Contributor Author

test added for 53

@WikiRik WikiRik requested a review from ezkemboi May 7, 2024 20:16
@rubiin rubiin removed the request for review from ezkemboi November 12, 2024 16:26
@rubiin rubiin merged commit def7f3e into validatorjs:master Nov 12, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants