Skip to content

test: split tests of large validators #2541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented Mar 28, 2025

Like in #2159 this PR splits tests of validators to their separate files. Based on #2159 (review) this PR tackles validators that have > 100 loc. Only isMobilePhone was not done here because of the 50+ open PRs for it.

I also ran prettier on the split test files so there are some styling changes.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

rubiin
rubiin previously approved these changes Mar 29, 2025
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (0a39bb7) to head (b564f40).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2541   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files         113      113           
  Lines        2527     2527           
  Branches      641      641           
=======================================
  Hits         2526     2526           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@WikiRik WikiRik requested a review from profnandaa April 8, 2025 17:16
@WikiRik
Copy link
Member Author

WikiRik commented Apr 8, 2025

Had to fix merge conflicts in regards to the recently merged isPostalCode changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants