Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ability for nat mapping through function #24

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

maxbronnikov10
Copy link
Contributor

The feature need when cluster nodes connected through dedicated subnet and you dont know exact host - only port
Also it would be useful if node failing and changing ip address

Changes:

  • Extend NatMap Type - union with object(previous) and function
  • Extend natMapper in Cluster for also work through function if it specified
  • Extend sentinelNatResolve in SentinelConnector for also work through function if it specified

Maybe fixes: redis/ioredis#1003

@maxbronnikov10 maxbronnikov10 force-pushed the feat/nat-mapping-through-fn branch from 9c4a7a7 to 9d4826a Compare January 21, 2025 21:34
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, I got a question.

README.md Show resolved Hide resolved
Signed-off-by: maxbronnikov10 <maxbronnikov2004@gmail.com>
@maxbronnikov10 maxbronnikov10 force-pushed the feat/nat-mapping-through-fn branch from 9d4826a to bc651d8 Compare January 23, 2025 18:43
@maxbronnikov10
Copy link
Contributor Author

i added more description why it is needed and simple example with k8s

README.md Outdated Show resolved Hide resolved
Signed-off-by: Matteo Collina <matteo.collina@gmail.com>
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 7e8fbf8 into valkey-io:main Jan 24, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClusterAllFailedError: Failed to refresh slots cache.
2 participants