Tests

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
valkey-io · Mar 5, 2025 · cb911f5 · cb911f5
1 parent 1d6198f
commit cb911f5
Show file tree

Hide file tree

Showing 3 changed files with 46 additions and 4 deletions.
diff --git a/csharp/lib/ConnectionConfiguration.cs b/csharp/lib/ConnectionConfiguration.cs
@@ -431,7 +431,7 @@ public T WithProtocolVersion(Protocol protocol)
         #endregion
         #region Client Name
         /// <summary>
-        /// Client name to be used for the client. Will be used with CLIENT SETNAME command during connection establishment.
+        /// Client name to be used for the client. Will be used with <c>CLIENT SETNAME</c> command during connection establishment.
         /// </summary>
         public string? ClientName
         {
@@ -530,7 +530,7 @@ public StandaloneClientConfigurationBuilder WithConnectionRetryStrategy(RetryStr
     /// Represents the configuration settings for a Cluster GLIDE client.<br />
     /// Notes: Currently, the reconnection strategy in cluster mode is not configurable, and exponential backoff with fixed values is used.
     /// </summary>
-    public class ClusterClientConfigurationBuilder : ClientConfigurationBuilder<StandaloneClientConfigurationBuilder>
+    public class ClusterClientConfigurationBuilder : ClientConfigurationBuilder<ClusterClientConfigurationBuilder>
     {
         public ClusterClientConfigurationBuilder() : base(true) { }
 

diff --git a/csharp/tests/Integration/StandaloneClientTests.cs b/csharp/tests/Integration/StandaloneClientTests.cs
@@ -0,0 +1,37 @@
+// Copyright Valkey GLIDE Project Contributors - SPDX Identifier: Apache-2.0
+
+namespace Tests.Integration;
+
+public class StandaloneClientTests
+{
+    [Fact]
+    public void CanConnectWithDifferentParameters()
+    {
+        _ = new GlideClient(TestConfiguration.DefaultClientConfig()
+            .WithClientName("GLIDE").Build());
+
+        _ = new GlideClient(TestConfiguration.DefaultClientConfig()
+            .WithTls(false).Build());
+
+        _ = new GlideClient(TestConfiguration.DefaultClientConfig()
+            .WithConnectionTimeout(2000).Build());
+
+        _ = new GlideClient(TestConfiguration.DefaultClientConfig()
+            .WithRequestTimeout(2000).Build());
+
+        _ = new GlideClient(TestConfiguration.DefaultClientConfig()
+            .WithDataBaseId(4).Build());
+
+        _ = new GlideClient(TestConfiguration.DefaultClientConfig()
+            .WithConnectionRetryStrategy(1, 2, 3).Build());
+
+        _ = new GlideClient(TestConfiguration.DefaultClientConfig()
+            .WithAuthentication("default", "").Build());
+
+        _ = new GlideClient(TestConfiguration.DefaultClientConfig()
+            .WithProtocolVersion(ConnectionConfiguration.Protocol.RESP2).Build());
+
+        _ = new GlideClient(TestConfiguration.DefaultClientConfig()
+            .WithReadFrom(new ConnectionConfiguration.ReadFrom(ConnectionConfiguration.ReadFromStrategy.Primary)).Build());
+    }
+}
diff --git a/csharp/tests/Integration/TestConfiguration.cs b/csharp/tests/Integration/TestConfiguration.cs
@@ -21,7 +21,12 @@ public static StandaloneClientConfigurationBuilder DefaultClientConfig() =>
         new StandaloneClientConfigurationBuilder()
             .WithAddress(STANDALONE_HOSTS[0].host, STANDALONE_HOSTS[0].port);
 
-    public static BaseClient DefaultStandaloneClient() => new GlideClient(DefaultClientConfig().Build());
+    public static ClusterClientConfigurationBuilder DefaultClusterClientConfig() =>
+        new ClusterClientConfigurationBuilder()
+            .WithAddress(CLUSTER_HOSTS[0].host, CLUSTER_HOSTS[0].port);
+
+    public static GlideClient DefaultStandaloneClient() => new(DefaultClientConfig().Build());
+    public static GlideClusterClient DefaultClusterClient() => new(DefaultClusterClientConfig().Build());
 
     private static TheoryData<BaseClient> s_testClients = [];
 
@@ -31,7 +36,7 @@ public static TheoryData<BaseClient> TestClients
         {
             if (s_testClients.Count == 0)
             {
-                s_testClients = [DefaultStandaloneClient()];
+                s_testClients = [(BaseClient)DefaultStandaloneClient(), (BaseClient)DefaultClusterClient()];
             }
             return s_testClients;
         }