Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.1] Update protoc #2421

Open
wants to merge 2 commits into
base: release-1.1
Choose a base branch
from
Open

[1.1] Update protoc #2421

wants to merge 2 commits into from

Conversation

Yury-Fridlyand
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand commented Oct 10, 2024 •
edited
Loading

Update protoc to most recent version.

Issue link

Closes #2694

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

@Yury-Fridlyand
update protoc
0c2d062 
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner October 10, 2024 18:03
@Yury-Fridlyand
update protoc
b4add58 
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand Yury-Fridlyand linked an issue Oct 10, 2024 that may be closed by this pull request
Update protobuf to the latest version #2423
Closed
2 tasks
@alexey-temnikov
Copy link
Collaborator

Please add issue and description.

avifenesh
avifenesh reviewed Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@avifenesh avifenesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide reasoning (it might be straight forward, but still).
What the version's main differences are (at least to what relevant for us).
Extra will be size differences between the versions.

@Yury-Fridlyand
Copy link
Collaborator Author

Just bumping protoc to most recent versions as possible. You can see full change lists on protobuf's repo: https://github.com/protocolbuffers/protobuf/releases

@Yury-Fridlyand Yury-Fridlyand added this to the 1.1 milestone Oct 11, 2024
jamesx-improving
jamesx-improving approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@jamesx-improving jamesx-improving left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve on confirmation of protobufjs used by node client doesn't need to be updated.

@Yury-Fridlyand
Copy link
Collaborator Author

Node client has the latest version already.

@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Oct 31, 2024
Merged
6 tasks
@acarbonetto acarbonetto self-requested a review November 7, 2024 18:13
acarbonetto
acarbonetto reviewed Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@acarbonetto acarbonetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should attach an Issue to this

@Yury-Fridlyand Yury-Fridlyand removed a link to an issue Nov 15, 2024
Update protobuf to the latest version #2423
Closed
2 tasks
@Yury-Fridlyand Yury-Fridlyand linked an issue Nov 15, 2024 that may be closed by this pull request
Bump protobuf for 1.1 version #2694
Open
@avifenesh avifenesh added dependency Dependency management and removed protobuf labels Nov 21, 2024
@Yury-Fridlyand Yury-Fridlyand changed the title Update protoc [1.1] Update protoc Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acarbonetto acarbonetto acarbonetto approved these changes

@avifenesh avifenesh avifenesh left review comments

@yipin-chen yipin-chen yipin-chen approved these changes

@jamesx-improving jamesx-improving jamesx-improving approved these changes

Assignees
No one assigned
Labels
dependency Dependency management
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

Bump protobuf for 1.1 version
6 participants
@Yury-Fridlyand @alexey-temnikov @avifenesh @acarbonetto @jamesx-improving @yipin-chen