Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java: fixed some spotbugs issues #2653

Draft
wants to merge 95 commits into
base: main
Choose a base branch
from
Draft

Java: fixed some spotbugs issues #2653

wants to merge 95 commits into from

Conversation

yipin-chen
Copy link
Collaborator

@yipin-chen yipin-chen commented Nov 8, 2024 •
edited
Loading

Issue link

#2612

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

shohamazon and others added 30 commits October 10, 2024 16:09
@shohamazon
Python: adds JSON.ARRLEN command (#2403)
fcc6001 
---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
@shohamazon
Python: adds JSON.CLEAR command (#2418)
a2ea32e 
Signed-off-by: Shoham Elias <shohame@amazon.com>
@prateek-kumar-improving
Python [FT.CREATE] command added(Created for release-1.2 branch) (#2426)
8fea303 
* Python [FT.CREATE] command added

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

---------

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
@Yury-Fridlyand
Java: FT.CREATE (#2414)
bbfce44 
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@GilboaAWS
Added inflightRequestsLimit client config to java (#2443)
855bb33 
Added inflightRequestsLimit client config to java (#2408)

* Add inflight request limit config to java

Signed-off-by: GilboaAWS <gilboabg@amazon.com>
@shohamazon
Fix CI failing (#2444)
705b404 
Signed-off-by: Shoham Elias <shohame@amazon.com>
@shohamazon
Fix mypy failing (#2453)
3661f87 
---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
@eifrah-aws
Make redis-rs part of this repo (#2456)
9d953d3 
* Make redis-rs part of this repo
* Improved PYTHON DEVELOPERS.md file
* Added Makefile for unified build method for all the languages
@Muhammad-awawdi-amazon @shohamazon
Python: add JSON.NUMINCRBY command (#2448)
1b3cad3 
---------

Signed-off-by: Muhammad Awawdi <Mawawdi@amazon.com>
Signed-off-by: Muhammad-awawdi-amazon <mawawdi@amazon.com>
Co-authored-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
@GilboaAWS
Added inflightRequestsLimit client config to Node (#2452)
04f0910 
* Added inflightRequestsLimit client config to Node

---------

Signed-off-by: GilboaAWS <gilboabg@amazon.com>
@Yury-Fridlyand
Java: Allow to run modules CI on demand. (#2416)
b255189 
* Run modules CI on demand.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@prateek-kumar-improving
Python FT.DROPINDEX command (#2437)
23a180b 
* Python [FT.DROPINDEX] Added command

---------

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
@Yury-Fridlyand
Update routing for commands from server modules. (#2461)
e51aa6d 
* Update routing for commands from server modules.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand @acarbonetto
Java: FT.DROPINDEX. (#2440)
9b9ccdb 
* `FT.DROPINDEX`.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
@Muhammad-awawdi-amazon @shohamazon
Python: Adds JSON.NUMMULTBY Command (#2458)
db785c9 
---------

Signed-off-by: Muhammad Awawdi <Mawawdi@amazon.com>
Co-authored-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
@eifrah-aws
redis-rs code cleanup: keep a single async runtime: tokio (#2459)
15d57b2 
Keep a single Runtime: `tokio`

- Removed dead code for `async-std`
- Fixed `redis-rs` tests so they could be run with a simple `cargo test` command
- Changed the default features to include: "tokio-comp", "tokio-rustls-comp", "connection-manager", "cluster", "cluster-async"
- Fixed a flaky `glide-core` test

Signed-off-by: Eran Ifrah <eifrah@amazon.com>
@Yury-Fridlyand
Fix python CI: fix linter installation (#2465)
1b6db03 
fix ci

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand
Java: FT.SEARCH (#2439)
c252cbb 
* `FT.CREATE`

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@prateek-kumar-improving
Python: Add commands FT.ALIASADD, FT.ALIASDEL, FT.ALIASUPDATE (#…
1125eba 
…2471)

* Python: Add commands FT.ALIASADD, FT.ALIASDEL, FT.ALIASUPDATE

---------

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
@jamesx-improving
Java: add JSON.SET and JSON.GET (#2462)
adcc76f 
* Java: add JSON.SET and JSON.GET

---------

Signed-off-by: James Xin <james.xin@improving.com>
@tjzhang-BQ @Yury-Fridlyand @cyip10
Node: Add CI support for server modules (#2472)
fa12563 
* Node: add server modules CI support

---------

Signed-off-by: TJ Zhang <tj.zhang@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Chloe <chloe.yip@improving.com>
Co-authored-by: TJ Zhang <tj.zhang@improving.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Chloe <chloe.yip@improving.com>
@Yury-Fridlyand
Java: FT.AGGREGATE. (#2468)
87412e8 
* `FT.AGGREGATE`.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand
Java: add FT.INFO (#2405)
d291d87 
* `FT.INFO`

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@cyip10 @acarbonetto
Java: FT.ALIASADD, FT.ALIASDEL, FT.ALIASUPDATE (#2442)
b168972 
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
@tjzhang-BQ
Node: add commands JSON.GET and JSON.SET (#2427)
91cafe8 
* Node: add commands JSON.GET and JSON.SET

Signed-off-by: TJ Zhang <tj.zhang@improving.com>
@Yury-Fridlyand
Java: JSON.ARRINSERT and JSON.ARRLEN (#2476)
56b4401 
* `JSON.ARRINSERT` and `JSON.ARRLEN`

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand
Run CI on PR merge on release branches (#2475)
6a3a33f 
* fix CI

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* fix CI

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

---------

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@barshaul
Avoid retrying on IO errors when it’s unclear if the server received …
914fd60 
…the request (#2479)

* Avoid retrying on IO errors when it’s unclear if the server received the request

Signed-off-by: barshaul <barshaul@amazon.com>
@avifenesh
Rust - code cleanup, part 1 (#2478)
695697a 
Some cleaning for unnecessary code to set the floor for next PR

Signed-off-by: avifenesh <aviarchi1994@gmail.com>
@yipin-chen
Java: add JSON.ARRAPPEND command (#2489)
76f68a6 
* Java: add JSON.ARRAPPEND command
---------
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
shohamazon and others added 26 commits October 29, 2024 15:13
@shohamazon
Python: adds JSON.RESP command (#2451)
2284c75 
---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
@Yury-Fridlyand
Java: Fix script kill IT (#2523)
ff39238 
* Fix script kill IT

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand
Add node REPL (#2355)
4af45f8 
* Add node REPL

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Muhammad-awawdi-amazon @shohamazon
Python: Add JSON.ARRINDEX Command (#2528)
5b90096 
---------

Signed-off-by: Muhammad Awawdi <Mawawdi@amazon.com>
Signed-off-by: Shoham Elias <shohame@amazon.com>
Co-authored-by: Shoham Elias <shohame@amazon.com>
@Yury-Fridlyand
Node: FT.INFO (#2540)
d4ef3c3 
* `FT.INFO`.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@tjzhang-BQ
Node: Add command JSON.STRLEN and JSON.STRAPPEND (#2537)
8ef77b6 
* Node: Add command JSON.STRLEN

Signed-off-by: TJ Zhang <tj.zhang@improving.com>
@Yury-Fridlyand
Node: JSON.ARRINSERT, JSON.ARRPOP and JSON.ARRLEN. (#2542)
6b06138 
* `JSON.ARRINSERT`, `JSON.ARRPOP` and `JSON.ARRLEN`.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@ikolomi
Fixes #2556 : Mutable default parameter in python example.
d598e24 
Signed-off-by: ikolomi <ikolomin@amazon.com>
@prateek-kumar-improving
Python: FT.PROFILE command added (#2543)
8a20b13 
* Python: FT.PROFILE command added

---------

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
@yipin-chen
Node: add ARRTRIM command (#2550)
23689db 
* Node: add ARRTRIM command

Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
@acarbonetto
Node: Add FT.SEARCH command (#2551)
788b6c8 
* Node: add FT.SEARCH

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

---------

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
@Muhammad-awawdi-amazon
PYTHON: Json.numincrby update (#2577)
58454c7 
---------

Signed-off-by: Muhammad Awawdi <Mawawdi@amazon.com>
@Muhammad-awawdi-amazon
PYTHON: Json.nummultby update (#2578)
c2d5e4a 
Signed-off-by: Muhammad Awawdi <Mawawdi@amazon.com>
@shohamazon
Python: adds JSON.ARRPOP command (#2407)
b091804 
---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
@barshaul
Fix benchmark CI error MISCONF
9340ea4 
Signed-off-by: barshaul <barshaul@amazon.com>
@shohamazon
Python: Round map values in tests for floating-point comparison (#2592)
db7b1bb 
---------

Signed-off-by: Ubuntu <ubuntu@ip-172-31-1-163.ec2.internal>
Signed-off-by: Shoham Elias <shohame@amazon.com>
Co-authored-by: Ubuntu <ubuntu@ip-172-31-1-163.ec2.internal>
@avifenesh @Yury-Fridlyand @shohamazon
Merge ci from main (#2584)
2b6578a 
* Update README.md nodejs platform support (#2397)

* Update README.md

Signed-off-by: Avi Fenesh <55848801+avifenesh@users.noreply.github.com>

* Update README.md - lint fix

Signed-off-by: Avi Fenesh <55848801+avifenesh@users.noreply.github.com>

* Update README.md ling

Signed-off-by: Avi Fenesh <55848801+avifenesh@users.noreply.github.com>

* Update node/README.md

Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Avi Fenesh <55848801+avifenesh@users.noreply.github.com>

---------

Signed-off-by: Avi Fenesh <55848801+avifenesh@users.noreply.github.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* CI - Minimal and full CI matrix impl (#2051)

* CI - Minimal and full CI matrix impl

Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Fix mypy failing (#2453)

---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Python: adds JSON.ARRLEN command (#2403)

---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>

---------

Signed-off-by: avifenesh <aviarchi1994@gmail.com>
Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
Co-authored-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>

* CI - Minimal and full CI matrix impl (#2051)

* CI - Minimal and full CI matrix impl

Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Fix mypy failing (#2453)

---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Python: adds JSON.ARRLEN command (#2403)

---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>

---------

Signed-off-by: avifenesh <aviarchi1994@gmail.com>
Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
Co-authored-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>

* CI - Minimal and full CI matrix impl (#2051)

* CI - Minimal and full CI matrix impl

Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Fix mypy failing (#2453)

---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Python: adds JSON.ARRLEN command (#2403)

---------

Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>

---------

Signed-off-by: avifenesh <aviarchi1994@gmail.com>
Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
Co-authored-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>

* Fix for - Minimal and full CI matrix impl #2051 (#2500)

* Refactor tests to use async cleanup and improve error handling

Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Enhance Jest configuration and add test setup file; update build scripts and dependencies

Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Update devDependencies in package.json for hybrid-node-tests to latest versions

Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Enhance test utilities and command tests with improved wait logic and version checks

Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Refactor tests to assert expected replica reads are less than or equal to actual reads; update connection handling in utilities and allow unused imports in types

Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Update dependencies and enhance PyO3 bindings; add new features and improve type handling

Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Update GitHub workflows: enhance linting configurations, adjust engine version requirements, and remove obsolete Redis installation workflow

Signed-off-by: avifenesh <aviarchi1994@gmail.com>

---------

Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* fixes for CI (#2552)

Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Refactor CI configuration for consistency and clarity

Signed-off-by: avifenesh <aviarchi1994@gmail.com>

* Refactor CI configuration for consistency and clarity

Signed-off-by: avifenesh <aviarchi1994@gmail.com>

---------

Signed-off-by: Avi Fenesh <55848801+avifenesh@users.noreply.github.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>
Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
@avifenesh
fixing full testing (#2601)
65bc84c 
Signed-off-by: avifenesh <aviarchi1994@gmail.com>
@eifrah-aws
Added Telemetry support for GLIDE client (core only) (#2545)
84d09a6
@avifenesh
Increase timeout for GlideClusterClient tests to 40000ms (#2606)
bb708be 
Signed-off-by: avifenesh <aviarchi1994@gmail.com>
@avifenesh
fix py wrapper build in container test (#2608)
e2746ee 
Signed-off-by: avifenesh <aviarchi1994@gmail.com>
@barshaul
CI: Increase request timeout to avoid timeout errors on noisy environ…
07d7a4b 
…ments (Go, Python, Node)

Signed-off-by: barshaul <barshaul@amazon.com>
@barshaul
Doc: Removed MacOS 12 from the tested platforms
2a3c053 
Signed-off-by: barshaul <barshaul@amazon.com>
@avifenesh
fix missing version (#2610)
ee4e448 
Signed-off-by: avifenesh <aviarchi1994@gmail.com>
@yipin-chen
Java: fixed some spotbugs issues
e3167bf 
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
@yipin-chen
Updated CHANGELOG
63c447a 
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
@Yury-Fridlyand Yury-Fridlyand added the java issues and fixes related to the java client label Nov 8, 2024
@yipin-chen yipin-chen changed the base branch from release-1.2 to main December 2, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand

@jamesx-improving jamesx-improving Awaiting requested review from jamesx-improving

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
java issues and fixes related to the java client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.