Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go: Add command ZAdd #2813

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Go: Add command ZAdd #2813

merged 2 commits into from
Dec 20, 2024

Conversation

tjzhang-BQ
Copy link
Collaborator

@tjzhang-BQ tjzhang-BQ commented Dec 14, 2024 •
edited by yipin-chen
Loading

Issue link

This Pull Request is linked to issue (URL): #2833

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

@tjzhang-BQ tjzhang-BQ force-pushed the go/tjz-zadd branch 2 times, most recently from e97a590 to d3cf0f5 Compare December 18, 2024 01:04
@tjzhang-BQ tjzhang-BQ marked this pull request as ready for review December 18, 2024 01:04
@tjzhang-BQ tjzhang-BQ requested a review from a team as a code owner December 18, 2024 01:04
@janhavigupta007 janhavigupta007 added the go golang wrapper label Dec 18, 2024
@yipin-chen yipin-chen mentioned this pull request Dec 18, 2024
Open
8 tasks
janhavigupta007
janhavigupta007 requested changes Dec 18, 2024
View reviewed changes
go/api/response_handlers.go Outdated Show resolved Hide resolved
go/api/options/zadd_options.go Outdated Show resolved Hide resolved
go/api/options/zadd_options.go Outdated Show resolved Hide resolved
go/api/options/zadd_options.go Outdated Show resolved Hide resolved
Go: Add command ZAdd
56142e2 
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
jbrinkman
jbrinkman approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@jbrinkman jbrinkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Yury-Fridlyand
Yury-Fridlyand reviewed Dec 19, 2024
View reviewed changes
go/api/base_client.go Outdated Show resolved Hide resolved
go/api/base_client.go Outdated Show resolved Hide resolved
go/api/options/zadd_options.go Outdated Show resolved Hide resolved
go/api/options/zadd_options.go Outdated Show resolved Hide resolved
go/api/sorted_set_commands.go Outdated Show resolved Hide resolved
go/api/options/zadd_options.go Show resolved Hide resolved
go/go.mod Show resolved Hide resolved
go/api/sorted_set_commands.go Outdated Show resolved Hide resolved
go/utils/transform_utils.go Outdated Show resolved Hide resolved
go/api/base_client.go Outdated Show resolved Hide resolved
yipin-chen
yipin-chen reviewed Dec 19, 2024
View reviewed changes
go/api/base_client.go Outdated Show resolved Hide resolved
Yury-Fridlyand
Yury-Fridlyand reviewed Dec 19, 2024
View reviewed changes
go/api/sorted_set_commands.go Outdated Show resolved Hide resolved
go/api/sorted_set_commands.go Outdated Show resolved Hide resolved
yipin-chen
yipin-chen approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@yipin-chen yipin-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we use ZAdd instead of Zadd?
After addressing all comments, you're good to merge.

address comments
14c3f87 
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
@tjzhang-BQ tjzhang-BQ merged commit 24a2dd0 into main Dec 20, 2024
17 of 18 checks passed
@tjzhang-BQ tjzhang-BQ deleted the go/tjz-zadd branch December 20, 2024 04:13
@tjzhang-BQ tjzhang-BQ restored the go/tjz-zadd branch December 21, 2024 00:14
@Yury-Fridlyand Yury-Fridlyand deleted the go/tjz-zadd branch December 23, 2024 18:49
niharikabhavaraju pushed a commit to niharikabhavaraju/valkey-glide that referenced this pull request Dec 29, 2024
@tjzhang-BQ @niharikabhavaraju
Go: Add command ZAdd (valkey-io#2813)
829fad6 
* Go: Add command ZAdd

Signed-off-by: TJ Zhang <tj.zhang@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand left review comments

@yipin-chen yipin-chen yipin-chen approved these changes

@janhavigupta007 janhavigupta007 janhavigupta007 approved these changes

@jbrinkman jbrinkman jbrinkman approved these changes

@prateek-kumar-improving prateek-kumar-improving Awaiting requested review from prateek-kumar-improving

Assignees
No one assigned
Labels
go golang wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tjzhang-BQ @jbrinkman @janhavigupta007 @Yury-Fridlyand @yipin-chen