Go: Add command ZScan #2950

tjzhang-BQ · 2025-01-14T04:07:10Z

Issue link

This Pull Request is linked to issue (URL): #2878

Checklist

Before submitting the PR make sure the following are checked:

This Pull Request is related to one issue.
Commit message has a detailed description of what changed and why.
Tests are added or updated.
CHANGELOG.md and documentation files are updated.
Destination branch is correct - main or release
Create merge commit if merging release branch into main, squash otherwise.

go/api/base_client.go

go/api/options/zscan_options.go

go/integTest/shared_commands_test.go

Yury-Fridlyand · 2025-01-14T18:36:30Z

go/api/base_client.go

+	if err != nil {
+		return CreateNilStringResult(), nil, err
+	}
+	return handleScanResponse(result)


Could you update please handleScanResponse to return (string, []string, error)? Those strings are never nil.
You can do it in another PR

I think I will do this in a separate PR for existing scan commands. Although when I was looking at the java code, the zscan API does also use the hanldeArrayOrNullResponse function when it takes binary inputs, is that a known behavior?

Could be a mistake. Feel free to fix that!

go/api/base_client.go

Yury-Fridlyand

CI is red

go/api/base_client.go

Signed-off-by: TJ Zhang <tj.zhang@improving.com>

tjzhang-BQ force-pushed the go/tjz-zscan branch from 8d058cc to 38d5844 Compare January 14, 2025 04:09

tjzhang-BQ temporarily deployed to AWS_ACTIONS January 14, 2025 04:09 — with GitHub Actions Inactive

tjzhang-BQ marked this pull request as ready for review January 14, 2025 04:09

tjzhang-BQ requested a review from a team as a code owner January 14, 2025 04:09

Yury-Fridlyand added the go golang wrapper label Jan 14, 2025

Yury-Fridlyand reviewed Jan 14, 2025

View reviewed changes

tjzhang-BQ force-pushed the go/tjz-zscan branch from 38d5844 to 736a69f Compare January 15, 2025 04:55

tjzhang-BQ had a problem deploying to AWS_ACTIONS January 15, 2025 04:55 — with GitHub Actions Error

tjzhang-BQ had a problem deploying to AWS_ACTIONS January 15, 2025 05:01 — with GitHub Actions Error

tjzhang-BQ had a problem deploying to AWS_ACTIONS January 15, 2025 05:02 — with GitHub Actions Error

Yury-Fridlyand reviewed Jan 15, 2025

View reviewed changes