Skip to content

Go: fix ld warnings on macos #3178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 15, 2025
Merged

Go: fix ld warnings on macos #3178

merged 7 commits into from
Feb 15, 2025

Conversation

Yury-Fridlyand
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand commented Feb 14, 2025

Partially fixes #3177 (1, 2, 3, 4 and 6 from #3177 (comment), 5 remains unfixed)

Fix following errors:

ld: warning: ignoring duplicate libraries: '-lglide_rs', '-lm'
ld: warning: search path '/Users/runner/work/valkey-glide/valkey-glide/go/api/errors/../rustbin/aarch64-apple-darwin' not found
ld: warning: search path '/Users/runner/work/valkey-glide/valkey-glide/go/api/target/release' not found
ld: warning: search path '/Users/runner/work/valkey-glide/valkey-glide/go/target/release' not found

(visible if GLIDE go glide is taken from the repo)

ld: warning: object file (/Users/runner/work/valkey-glide/valkey-glide/go/target/release/libglide_rs.a....) was built for newer 'macOS' version (14.5) than being linked (14.0)

Error

ld: warning: search path '/Users/runner/work/valkey-glide/valkey-glide/go/api/../rustbin/aarch64-apple-darwin' not found

is visible to developers only

The error (actually a warning) like

ld: warning: '/private/var/folders/2s/h6hvv9ps03xgz_krkkstvq_r0000gn/T/go-link-197988188/000019.o' has malformed LC_DYSYMTAB, expected 98 undefined symbols to start at index 1626, found 95 undefined symbols starting at index 1626

remains unfixed. See there more details about it.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand
Copy link
Collaborator Author

Full matrix test: https://github.com/valkey-io/valkey-glide/actions/runs/13340488396
(ignore linux-arm failures caused by missing npm on the self-hosted runners)

@Yury-Fridlyand Yury-Fridlyand marked this pull request as ready for review February 15, 2025 01:55
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner February 15, 2025 01:55
@Yury-Fridlyand Yury-Fridlyand changed the title Remove duplicating cgo flags. Go: fix ld warnings on macos Feb 15, 2025
@yipin-chen yipin-chen requested a review from jbrinkman February 15, 2025 02:26
@yipin-chen yipin-chen merged commit 04726b1 into release-1.3 Feb 15, 2025
47 of 55 checks passed
@yipin-chen yipin-chen deleted the go/fix-ldflags branch February 15, 2025 17:30
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go 🏃 golang wrapper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants